fix #19480 last tied note accidentals

[sammik]

Resolves: #19480

Caused by 43df579

Last tied note was excluded by for loop condition

I reverted that change and added other safety check(s)

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[sammik]

@mike-spa

[cbjeukendrup]

Why not:

Suggested change

	Note* nn = n;
	while (nn && nn->tieFor()) {
	nn = nn->tieFor()->endNote();
	if (nn) {
	score->undo(new ChangePitch(nn, pitch, tpc1, tpc2));
	}
	}
	for (Note* nn = n; nn; nn = nn->tieFor() ? nn->tieFor()->endNote() : nullptr) {
	score->undo(new ChangePitch(nn, pitch, tpc1, tpc2));
	}

[sammik]

Why not:

I think

1. becouse endNote() may by nullptr, so we would need nullcheck anyway
2. because we dont need to change n (which is tie start note), but need to start with next tied note

[cbjeukendrup]

1. becouse endNote() may by nullptr, so we would need nullcheck anyway

That would be done by the ; nn;.

Anyway, I'll stop nitpicking about things like this :)