Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't consider frame gap above/below when laying out pages #19485

Merged
merged 1 commit into from Oct 4, 2023

Conversation

miiizen
Copy link
Contributor

@miiizen miiizen commented Sep 22, 2023

Resolves: #13766

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@miiizen miiizen marked this pull request as draft September 22, 2023 13:19
@miiizen miiizen marked this pull request as ready for review September 22, 2023 13:40
@oktophonie
Copy link
Contributor

I'm not sure I like this solution. One should be able to change the value even if, in the current context, it has no visual effect. Maybe a relayout causes a frame to end up moving to the end of the previous page, or to the top of the next, and you want to clear the (now redundant) value, but you can't because it's been disabled, for example. Or, for a frame at the end of a page, you might want set the gap below 'pre-emptively' for a situation where things have reflowed and it's no longer at the bottom.

I think it would be better to fix the root problem, and prevent 'gap below' from being taken into account when the frame is at the bottom of the page. But the user can still change it, and if the frame is later moved, the value they have set will be relevant. (And same for 'gap above' when a frame is at the top of a page.)

@miiizen miiizen changed the title Disable gap spinboxes on frames preceding/following page breaks Don't consider frame gap above/below when laying out pages Sep 28, 2023
@cbjeukendrup cbjeukendrup merged commit 186dbac into musescore:master Oct 4, 2023
10 of 11 checks passed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Oct 4, 2023
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Gap below" of a frame (placed at the end of a page) is ineffective but still reserving space
3 participants