MusicXML: Add export for smufl noteheads #19506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rettinghaus
force-pushed
the
xmlnoteheads
branch
from
07ef159
to
a93fca4
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 25, 2023
Adresses notehead issue from musescore#17553 Backport of musescore#19506
rettinghaus
force-pushed
the
xmlnoteheads
branch
from
7862c0d
to
1bd0f6a
Compare
|
@cbjeukendrup could you have a look here, please? |
|
Here too it would be nice to have a test file where we see this new code in action. But the code itself looks good to me! |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Oct 1, 2023
Adresses notehead issue from musescore#17553 Backport of musescore#19506
|
@cbjeukendrup test added |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Oct 1, 2023
Adresses notehead issue from musescore#17553 Backport of musescore#19506
cbjeukendrup
approved these changes
Oct 1, 2023
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Oct 1, 2023
Adresses notehead issue from musescore#17553 Backport of musescore#19506
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Oct 2, 2023
Adresses notehead issue from musescore#17553 Backport of musescore#19506
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Oct 2, 2023
Adresses notehead issue from musescore#17553 Backport of musescore#19506
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Oct 2, 2023
Adresses notehead issue from musescore#17553 Backport of musescore#19506
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Oct 2, 2023
Adresses notehead issue from musescore#17553 Backport of musescore#19506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses notehead issue from #17553