fix #56556: set correct track for volta #1954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More about it tomorrow, but I think it was the intent so we should fix the parts + the line... |
|
Fair enough. Eventually we might consider the same for tempo, repeat, and the other element types handled here, which are currently always hard-coded to appear on staff 0. |
|
Great, I look forward to checking out the new volta code - it does seem like it will be a nice enhancement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent fix for a crash and other issues upon trying to add a volta to a staff other than the top had the side effect of making the volta actually appear on the staff to which you dragged it, rather than always appearing on the top staff only. I am assuming this was inadvertent. My change here fixes that, in a manner consistent with the rest of the code here. There are other ways this could have been fixed, probably simpler too; see discussion in issue report.
If the intent really is to allow voltas to be attached to non-top staves, we should fix how they are linked to parts, probably also fix the dotted line to the top staff that appears while dragging the volta to your score.