factor notehead offset into stem length calculations

[miiizen]

Resolves: #19488
Stems no longer extend when changing notehead offset.

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[zacjansheski]

Stems still extend when they are beamed

video1431782670.mp4

[cbjeukendrup]

Same as https://github.com/musescore/MuseScore/pull/19559/files#r1341666459; startNote->layoutData()->pos() would be a more direct way of getting the desired value

[miiizen]

I've prevented the beamed notes stems from extending by subtracting the notehead offset in the value returned by BeamTremoloLayout::chordBeamAnchorY. This also prevents beams moving with the notehead offset. However this is less consistent with BeamTremoloLayout::chordBeamAnchorX, as this includes offset in the value it returns. Would subtracting the offset each time BeamTremoloLayout::chordBeamAnchor is called be preferred?

[zacjansheski]

I've prevented the beamed notes stems from extending by subtracting the notehead offset in the value returned by BeamTremoloLayout::chordBeamAnchorY. This also prevents beams moving with the notehead offset. However this is less consistent with BeamTremoloLayout::chordBeamAnchorX, as this includes offset in the value it returns. Would subtracting the offset each time BeamTremoloLayout::chordBeamAnchor is called be preferred?

The current solution seems good to me. Are there any anticipated problems related to the BeamTremoloLayout::chordBeamAnchorX inconsistency?

[cbjeukendrup]

I think it's fine; actually it's not that inconsistent, because if I'm not mistaken, the implementation of chordBeamAnchorX does ultimately not work with notes at all and thus doesn't take any note offset into account anyway.

[cbjeukendrup]

@zacjansheski Shall we merge it in that case?
(@miiizen Any objections?)

[cbjeukendrup]

Oh, wait a minute, a rebase is needed as layoutData has been renamed to ldata!

[miiizen]

@cbjeukendrup no, as long as you're happy with it go ahead!