Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #19483 correct staff for editing instrument after instrumentChange #19566

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

sammik
Copy link
Contributor

@sammik sammik commented Sep 30, 2023

Resolves: #19483

Part::endTrack() returns first track of next Part. We need last track of current Part.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@zacjansheski
Copy link
Contributor

Tested on Mac OS 11.6.5, Ubuntu 20.04.6, Windows 11
#19483 FIXED

@cbjeukendrup cbjeukendrup merged commit 48bcfbc into musescore:master Oct 2, 2023
11 checks passed
@sammik sammik deleted the instrumentChange-wrong-staff branch October 2, 2023 17:51
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"change instrument text" on score affecting wrong line
3 participants