Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower macOS deployment target to 10.13 #19570

Conversation

cbjeukendrup
Copy link
Contributor

Back in the days, we chose 10.14, because:

  • We still believed that we would switch to Qt 6 with MuseScore 4.1
  • Qt 6 required 10.14
  • We wanted to do a OS requirement bump from MuseScore 3.6 to 4.0, not from 4.0 to 4.1

But things turned out differently:

  • Switching to Qt 6 is not going to happen anytime soon (there are too many things that are just not working or still missing; and why would we even switch, since the open source world is still receiving LTS updates for Qt 5.15, albeit with one year delay with respect to commercial users)
  • Nowadays, Qt 6 requires even 10.15 or even 11.0 (different documentation pages say different things)

So there is no point anymore in artificially limiting MuseScore to macOS 10.14+. This PR lifts that restriction, so that MuseScore 4.2 will run on macOS 10.13 (which is really required, by Qt 5.15).

@cbjeukendrup
Copy link
Contributor Author

Wow, that's interesting: it only works if we use the latest Xcode version. That's a bit surprising. Apparently they added backdeployment for more C++ std APIs in the latest version.
Anyway, using a newer Xcode version is not a bad thing; and Xcode 15 still supports macOS 10.13 as a deployment target, and there are no unusual warnings printed, so I think it should be fine. Still would be good to actually test this on a (virtual) 10.13 machine.

@cbjeukendrup
Copy link
Contributor Author

Update about this:

  • Zac reported (long ago already) that builds from this PR crash on all macOS versions older than 13.0 (something like that)
  • That turns out to be a problem with the linker in Xcode 15.0
  • Xcode 15.1 fixes this, and is out since Dec 5th; and now finally also available on GitHub Actions. So let's try again!

@cbjeukendrup cbjeukendrup marked this pull request as ready for review December 25, 2023 14:02
Copy link
Contributor

@shoogle shoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on macOS 11.6.8. That's the only version I have access to currently.

@bkunda bkunda added the needs info More information is required before action can be taken label Jan 24, 2024
@bkunda
Copy link

bkunda commented Jan 24, 2024

With a move to Qt6 on the horizon (which will support macOS 10.14), it is no longer necessary for us to lower the deployment target to 10.13. As such, this PR can be closed.

@bkunda bkunda closed this Jan 24, 2024
@cbjeukendrup cbjeukendrup deleted the macos_lower_deployment_target branch January 24, 2024 12:36
@cbjeukendrup
Copy link
Contributor Author

cbjeukendrup commented Jan 24, 2024

(which will support macOS 10.14)

It doesn't; it doesn't even support 10.15, but only 11 and newer, and soon only 12 and newer. So switching to Qt 6 will cause a huge bump in our system requirements.

Also, lowering the deployment target wasn't necessary, but a welcome feature for some people.

@igorkorsukov
Copy link
Contributor

(which will support macOS 10.14)

It doesn't; it doesn't even support 10.15, but only 11 and newer, and soon only 12 and newer. So switching to Qt 6 will cause a huge bump in our system requirements.

Also, lowering the deployment target wasn't necessary, but a welcome feature for some people.

We can switch to 6.2 first, but it has its own problems, we’ll try to solve them.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs info More information is required before action can be taken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants