Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #19576 title frame to all parts in xml import file #19606

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

sammik
Copy link
Contributor

@sammik sammik commented Oct 3, 2023

Resolves: #19576

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@sammik
Copy link
Contributor Author

sammik commented Oct 4, 2023

I am bit confused of vtest fail, as only change in this PR is musicxml import, so it should be unrelated.

@cbjeukendrup
Copy link
Contributor

Indeed it seems impossible that it is related to this PR. Probably some kind of race condition with another PR, or the PR branch is not up-to-date with latest master. Most likely a rebase will fix it.

@cbjeukendrup cbjeukendrup requested review from mike-spa and removed request for cbjeukendrup October 4, 2023 13:21
@sammik sammik force-pushed the xml-import-title-frame-parts branch from ccfd4b0 to 8e73ab9 Compare October 4, 2023 13:25
Copy link
Contributor

@mike-spa mike-spa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@cbjeukendrup cbjeukendrup merged commit e4c02f3 into musescore:master Oct 12, 2023
11 checks passed
@sammik sammik deleted the xml-import-title-frame-parts branch October 12, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title Frame not present in parts from an imported XML file
4 participants