Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search score, not just staves for linked system elements #19773

Merged
merged 1 commit into from Oct 20, 2023

Conversation

miiizen
Copy link
Contributor

@miiizen miiizen commented Oct 19, 2023

Resolves: #19472
Resolves: #18231

When checking if an element had already been added to a staff which was being cloned, we were only checking staves with the same id. This was missing system elements, which frequently aren't on the same staff in parts as they are in the score.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@DmitryArefiev
Copy link
Contributor

Tested #19472 on Win10, Mac13.6, LinuxUbuntu 22.04 - FIXED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants