Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check a note is on a visible stave before checking cross staff validity #19789

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

miiizen
Copy link
Contributor

@miiizen miiizen commented Oct 20, 2023

Resolves: #19765

This was causing issues in parts where an instrument with cross staff notes had been added and then hidden again. This caused the note to fail the checkStaffMoveValidity check, when the staff wasn't visible and shouldn't have been checked.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup cbjeukendrup merged commit 247cea9 into musescore:master Oct 20, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messed up 8th note connection bar across staves
3 participants