fix #59176: crash on add/remove line breaks with mmrest #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasconic
added a commit
that referenced
this pull request
May 9, 2015
fix #59176: crash on add/remove line breaks with mmrest
|
I merged this one but then realised that a couple of mtests would be great. Could you do that? |
|
Yes, that would be good. Right now there are no tests for this function On Sat, May 9, 2015 at 3:04 AM, Nicolas Froment notifications@github.com
Marc Sabatella |
|
My guess too. That's how we do it for most of the other things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash was a simple null dereference error, but it pointed out a more fundametal issue with how this command deals with mmrests.
This PR treats mmrests as a single measure (which they are at some level) for the purpose of counting how many measures to put on a line. This much required only changing lastMeasure and nextMeasure to lastMeasureMM and nextMeasureMM respectively. However, adding a line break to an mmrest doesn't actually work. Apparently, everywhere else in the code where we add line breaks, we check for mmrests and add the break to the last real measure instead. So I do that here as well.