Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19918: Tremolo beam disappearing #19973

Merged

Conversation

HemantAntony
Copy link
Contributor

Resolves: #19918

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@oktophonie
Copy link
Contributor

Not sure what the vtest change here is about, though it doesn't particularly concern me; the issue itself seems to be fixed in this PR.

@oktophonie oktophonie added the vtests This PR produces approved changes to vtest results label Nov 8, 2023
@HemantAntony
Copy link
Contributor Author

Oh okay, that sounds great. I was a bit worried about that

@cbjeukendrup
Copy link
Contributor

When I enable Diagnostics > Engraving > Color element shapes, it seems this change seems to have an not-exclusively-positive effect on the calculated shapes:

Before After
Scherm­afbeelding 2023-11-08 om 23 47 11 Scherm­afbeelding 2023-11-08 om 23 44 40

@oktophonie oktophonie removed the vtests This PR produces approved changes to vtest results label Nov 10, 2023
@cbjeukendrup cbjeukendrup merged commit 347f32e into musescore:master Nov 10, 2023
11 checks passed
@HemantAntony HemantAntony deleted the 19918-tremolo-beam-disappearing branch November 11, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tremolo beam disappearing
4 participants