Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #59306: crash when printing to PDF printer #1998

Closed
wants to merge 1 commit into from
Closed

fix #59306: crash when printing to PDF printer #1998

wants to merge 1 commit into from

Conversation

Jojo-Schmitz
Copy link
Contributor

No description provided.

@Jojo-Schmitz
Copy link
Contributor Author

PR updated, uses an int again, but makes sure to set it to 1 in case devicePixelRatio() returns a 0.
Works fine here, including proper PDF output

@lasconic
Copy link
Contributor

lasconic commented May 8, 2015

Same fix applied here 7fbf11f

Thank you for the investigation!

@lasconic lasconic closed this May 8, 2015
@Jojo-Schmitz
Copy link
Contributor Author

Seems with 89d455f and/or 3e383af and/or 7fbf11f this isn't needed anymore

@Jojo-Schmitz
Copy link
Contributor Author

oops, posts crossed

@Jojo-Schmitz Jojo-Schmitz deleted the pdf-printer-crash branch May 8, 2015 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jojo-Schmitz @lasconic