Add figured bass to parts & score #20139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 22, 2023
miiizen
force-pushed
the
17625-fb-parts
branch
from
46cd280
to
77ae45a
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 22, 2023
miiizen
force-pushed
the
17625-fb-parts
branch
from
77ae45a
to
4022859
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 23, 2023
oktophonie
approved these changes
Nov 23, 2023
miiizen
force-pushed
the
17625-fb-parts
branch
from
b4e5a47
to
91947a5
Compare
cbjeukendrup
approved these changes
Nov 23, 2023
|
Strange, a full backport of this to Mu3 crashes on undo, but the first version of this PR, these 2 1-line additions in edit.cpp, seem to be enough to fix the entire issue, and without any undo issue |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 24, 2023
Backport of musescore#20139 (of its pretty minimal first version, the rest introduces a crash on undo, and apparently Mu3 doesn't have the undo issue of Mu4/master)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 24, 2023
Backport of musescore#20139 (of its pretty minimal first version, the rest introduces a crash on undo, and apparently Mu3 doesn't have the undo issue of Mu4/master)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 24, 2023
Backport of musescore#20139 (of its pretty minimal first version, the rest introduces a crash on undo)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 6, 2023
Backport of musescore#20139 (of its pretty minimal first version, the rest introduces a crash on undo, and apparently Mu3 doesn't have the undo issue of Mu4/master)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 6, 2023
Backport of musescore#20139 (of its pretty minimal first version, the rest introduces a crash on undo, and apparently Mu3 doesn't have the undo issue of Mu4/master)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 8, 2023
Backport of musescore#20139 (of its pretty minimal first version, the rest introduces a crash on undo, and apparently Mu3 doesn't have the undo issue of Mu4/master)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #17625
Figured bass is now linked between parts and score.
Undo still doesn't update the text of the figured bass item.