More tie refinements #20161
Merged
More tie refinements #20161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (tieLengthInSp > shortTieLimit) { | ||
| m_midThickness = normalThickness; | ||
| } else { | ||
| const double A = 1 / (shortTieLimit - minTieLength); |
There was a problem hiding this comment.
You should check if shortTieLimit and minTieLength are equal
There was a problem hiding this comment.
@RomanPudashkin this is ok now, I've put the check a few lines above :)
mike-spa
force-pushed
the
tieRefinements
branch
from
b69bfe1
to
609dcf5
Compare
mike-spa
force-pushed
the
tieRefinements
branch
from
609dcf5
to
0b2916c
Compare
oktophonie
approved these changes
Nov 24, 2023
RomanPudashkin
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #19532 (a bunch of tie layout cases - see vtests).
Also, there used to be a sqrt operation in Tie::computeMidThickness which was causing performance issues. Now I've changed the formula to a different one so it also fixes that for free.