Add support for sostenuto pedal to MusicXML and MEI #20219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/importexport/musicxml/internal/musicxml/importmxmlpass2.cpp
Outdated
Show resolved
Hide resolved
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 27, 2023
…/export Backport of musescore#20219
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 27, 2023
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 27, 2023
Backport of (the MusicXML part of) musescore#20219
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 27, 2023
Backport of (the MusicXML part of) musescore#20219
|
@Jojo-Schmitz thanks for having a look! Now everything should be fine. |
|
What about the test file? |
|
@lpugin test file is updated. |
lpugin
reviewed
Nov 28, 2023
rettinghaus
force-pushed
the
sostenuto
branch
2 times, most recently
from
32db03a
to
fa75fc6
Compare
cbjeukendrup
force-pushed
the
sostenuto
branch
from
fa75fc6
to
d3c5f23
Compare
cbjeukendrup
approved these changes
Nov 30, 2023
|
@cbjeukendrup thanks! |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 2, 2023
Backport of (the MusicXML part of) musescore#20219
oktophonie
approved these changes
Dec 4, 2023
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 4, 2023
Backport of (the MusicXML part of) musescore#20219
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 4, 2023
Backport of (the MusicXML part of) musescore#20219
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 4, 2023
Backport of (the MusicXML part of) musescore#20219
|
@rettinghaus please open the same PR for 4.2.1. Thanks! |
|
@RomanPudashkin with pleasure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the sostenuto pedal signs to MusicXML import/export and MEI import/export.
The addition of
pedal-type"sostenuto" completes thepedalsupport for MusicXML.Additionally it fixes problems with
pedal-type="resume", which should only appear if the pedal has actually aline="yes", and that in some cases a symbol was shown even forsign="no".testPedalChanges.xmlhas been updated to do a complete i/o round and another pedal test has been added.