-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #18158: Do not export invisible text lines #20225
Conversation
Shouldn't the line be exported as invisible, rather than not exported at all? |
How about _xml.startElement("direction-type");
if (!tl->lineVisible())
_xml.tag("dashes", { { "dash-length", 0} });
} else if (isDashes) {
_xml.tag("dashes", { { "type", type }, { "number", n + 1 } });
} else {
_xml.tagRaw(QString("bracket type=\"%1\" number=\"%2\" line-end=\"%3\"%4").arg(type, QString::number(n + 1), lineEnd, rest));
}
_xml.endElement(); Something similar is used for invisible (de-)crecendo lines |
Probably requires the import to handle this too const qreal dashLenght { _e.attributes().value("dash-length").isEmpty() ? -1.0 : _e.attributes().value("dash-length").toDouble() };
if (ashLenght != 0) {
b->setLineVisible(false); // hack: export encodes invisible dash lines with a dashLength of 0
b->setLineStyle(Qt::DashLine);
} |
@oktophonie There isn't such a thing as invisible lines in MusicXML. The |
This comment was marked as outdated.
This comment was marked as outdated.
4327378
to
bb824ff
Compare
@oktophonie Thanks for testing. The previously "fixed" export of invisible (de)crescendo lines showed the same problem. Now everything should be as expected. |
closes #18158