Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MusicXML: Correctly export all trill types #20285

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

rettinghaus
Copy link
Contributor

This PR addresses some more of the problems reported in #17553:

  • the stroke and wedge articulations are now exported as spiccato and staccatissimo respectively
  • the upprall, downprall, and prallprall lines are now exported as wavy-line elements with the correct start glyph as other-ornament with a smufl attribute

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Dec 2, 2023
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Dec 2, 2023
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Dec 2, 2023
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Dec 5, 2023
@rettinghaus rettinghaus changed the title Correctly export all trill types MusicXML: Correctly export all trill types Jan 10, 2024
@rettinghaus rettinghaus force-pushed the xml/missing-notations branch 4 times, most recently from c553482 to a384563 Compare February 2, 2024 12:42
@rettinghaus
Copy link
Contributor Author

@hhpmusic Would you please check this one out?

@hhpmusic
Copy link

hhpmusic commented Feb 9, 2024

Thanks, but I can't test it. All files export as 0-byte Musicxml files. The Musicxml export module completely fails.

@rettinghaus
Copy link
Contributor Author

Weird. I'll check.

@hhpmusic
Copy link

hhpmusic commented Feb 9, 2024

I created another issue. It exports compressed xml well, but uncompressed 0-byte.

@hhpmusic
Copy link

hhpmusic commented Feb 9, 2024

Strange, at my side it only converts compressed one.

@rettinghaus
Copy link
Contributor Author

@hhpmusic I did a rebase. Would you please be so kind to test again?

@hhpmusic
Copy link

Thanks, it works. However, the prallprall line just exports a wavy line. Is this correct? I hear the playback is not the same as a usual trill.

@rettinghaus
Copy link
Contributor Author

I can't speak for the playback, but for MusicXML a Prall Prall is just a wavy line.

@hhpmusic
Copy link

If so, this is fixed successfully. Thanks!

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Feb 11, 2024
@rettinghaus rettinghaus force-pushed the xml/missing-notations branch 2 times, most recently from 21bfbfa to 938f913 Compare February 13, 2024 13:37
@cbjeukendrup
Copy link
Contributor

@rettinghaus You probably rebased in an unfortunate moment and therefore there are now a lot of commits that don't belong here. Could you try rebasing again?

@Jojo-Schmitz
Copy link
Contributor

Actually @igorkorsukov did that bogus rebase, as far as I can tell

only set trill-mark for trill symbol
correctly handle upprall and downprall
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Feb 17, 2024
@igorkorsukov
Copy link
Contributor

Actually @igorkorsukov did that bogus rebase, as far as I can tell

Sorry for the inconvenience

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Feb 17, 2024
@rettinghaus
Copy link
Contributor Author

@oktophonie mind to have a look at this one?

@igorkorsukov igorkorsukov merged commit 05f109d into musescore:master Mar 11, 2024
11 checks passed
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 11, 2024
@rettinghaus rettinghaus deleted the xml/missing-notations branch March 11, 2024 10:40
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 11, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants