-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MusicXML: Correctly export all trill types #20285
MusicXML: Correctly export all trill types #20285
Conversation
d795bb0
to
9cb531a
Compare
9cb531a
to
05a2bbd
Compare
c553482
to
a384563
Compare
@hhpmusic Would you please check this one out? |
a384563
to
16ed96a
Compare
Thanks, but I can't test it. All files export as 0-byte Musicxml files. The Musicxml export module completely fails. |
Weird. I'll check. |
I created another issue. It exports compressed xml well, but uncompressed 0-byte. |
16ed96a
to
59122ee
Compare
Strange, at my side it only converts compressed one. |
@hhpmusic I did a rebase. Would you please be so kind to test again? |
Thanks, it works. However, the prallprall line just exports a wavy line. Is this correct? I hear the playback is not the same as a usual trill. |
I can't speak for the playback, but for MusicXML a Prall Prall is just a wavy line. |
If so, this is fixed successfully. Thanks! |
21bfbfa
to
938f913
Compare
a1759cc
to
a9c7ead
Compare
fa1f8d3
to
525a11a
Compare
@rettinghaus You probably rebased in an unfortunate moment and therefore there are now a lot of commits that don't belong here. Could you try rebasing again? |
Actually @igorkorsukov did that bogus rebase, as far as I can tell |
only set trill-mark for trill symbol correctly handle upprall and downprall
938f913
to
9c6c3b0
Compare
Sorry for the inconvenience |
@oktophonie mind to have a look at this one? |
This PR addresses some more of the problems reported in #17553:
stroke
andwedge
articulations are now exported asspiccato
andstaccatissimo
respectivelyupprall
,downprall
, andprallprall
lines are now exported aswavy-line
elements with the correct start glyph asother-ornament
with a smufl attribute