Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved notenames plugin #204

Closed
wants to merge 4 commits into from
Closed

improved notenames plugin #204

wants to merge 4 commits into from

Conversation

Jojo-Schmitz
Copy link
Contributor

including i8n and l10n

including i8n and l10n
@Jojo-Schmitz
Copy link
Contributor Author

Please hold on merging it, it does work, but still only on the top note of voice 1 and only on the entire score.
I'd like to extend it to work on all notes of all voices, and ideally also on a selection if there is one, else on the entire score.

but still on the entire score
if there is one, on entire score othwerwise
@Jojo-Schmitz
Copy link
Contributor Author

I think this is now ready for merging. Let me know if you think otherwise

works on a selection if there is one, on the entire score otherwise,
shamelessly stolen from lasocinc's Gist at
https://gist.github.com/lasconic/4731684
Also uncolors on 2nd run, idea taken from
http://musescore.org/de/project/colornotesextended
@Jojo-Schmitz
Copy link
Contributor Author

while at it I've now improved the colornotes plugin too. No i18n there...

@lasconic
Copy link
Contributor

lasconic commented Feb 8, 2013

I'm not a big fan of having all these TS and QM files in the repository but I don't have a good solution yet. I will think about it.

@Jojo-Schmitz
Copy link
Contributor Author

Well, Werner encouraged me to provide a better notenames plugin. And even without the translations I think it is better than the current one.

And the colornotes one doesn’t have any translations

Bye, Jojo

From: Nicolas Froment [mailto:notifications@github.com]
Sent: Friday, February 08, 2013 6:54 PM
To: musescore/MuseScore
Cc: Joachim Schmitz
Subject: Re: [MuseScore] improved notenames plugin (#204)

I'm not a big fan of having all these TS and QM files in the repository but I don't have a good solution yet. I will think about it.


Reply to this email directly or view it on GitHub #204 (comment) ..

https://github.com/notifications/beacon/J6T91GIPIyhU-8ti4GCGP5ca8j_PFR4FvKIIiyiX3pw23ii4jvuWP-DBbiRHJ86Z.gif

@lasconic
Copy link
Contributor

lasconic commented Feb 9, 2013

If you don't mind I will merge them manually for the moment and without the translations.

@Jojo-Schmitz
Copy link
Contributor Author

I’m fine with that.

@lasconic
Copy link
Contributor

lasconic commented Feb 9, 2013

Done. Thank you.
I guess this overhaul of these two plugins highlighted several problems right?

  • No way to translate the menu item of the plugin?
  • rewind(int) is not really user friendly
  • not sure cursor.segment is the best way in the world to detect end of score

What do you think?

@lasconic lasconic closed this Feb 9, 2013
@Jojo-Schmitz
Copy link
Contributor Author

Yes this pretty much summarizes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants