fix #63481: scale symbols, trill lines, arpeggios, and glissandi #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschweer
added a commit
that referenced
this pull request
Jun 10, 2015
fix #63481: scale symbols, trill lines, arpeggios, and glissandi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, none of these elements scale with staff size. There a few ways one could make this happen, I went for the easiest: explictly setting _mag during layout. This is also the approach used for Accidental, maybe other elements. Another approach might have been to override mag(), as is done for TimeSig, Articulation, and other elements. Another might have been to factor in staff magnification at the points where it is used, but this seems more likely to be difficult to get right.
I also improved my previous fix for the scaling of text lines, to make sure the track for the text is always kept to date.