Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashing of tuning plugins by Bill Hails #20537

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jacobdill75
Copy link

Resolves: #19326

When developing my own tuning plugin for MS4 on MacOS, I noticed that since 4.1, Qt Text components would crash only on Mac (fine on windows 10+). I then noticed that the vanilla tuning plugins by Bill Hails also crashes for the same reason.

While I made the "simplest" changes to fix this crash (updating Qt.Controls version in the plugin implementations), one downside of this fix is the loss of theming that was inherited by earlier Qt.Controls packages (somehow). Consider the before and after:

image

This may raise accessibility concerns, in addition to the fact that these changes will be made to both Windows and Mac, despite the crash only occurring on Mac. My preferred patch (if I could budget the time) would be either (i) to deploy the patched version only for Mac, or (ii) to rewrite the plugin using MuseScore.UIComponents as mentioned here.

Nonetheless, I hope that this PR can at least inspire the changes that fixes these plugins for MacOS, as they have served me well for microtonal compositions.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MU4 Issue] MacOS Crash on Plugin with TextField Component
1 participant