fix #54221: bd layout with measure after horizontal frame #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. @wschweer any opinion? |
|
looks ok for me |
wschweer
added a commit
that referenced
this pull request
Jun 27, 2015
fix #54221: bd layout with measure after horizontal frame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
layoutSystem() always takes at least one measure, thus forcing at least one measure to always appear after a horizontal frame whether it fits or not. This change checks the return value from layoutSystem() to be sure it really fits in the row.
I also fixed a glitch in the next line, where we are trying to decide if the last system row needs to be filled, but we actually check only the last system within the row, so we don't fill some systems we should.