fix #66241: note offset not preserved for tab

[MarcSabatella]

I believe I broke this here:

fbc6761

Formerly, Note::layout2() called adjustReadPos(). I needed to move that earlier for pitched staff calculations, but in doing so, I neglected to handle the tab case. For all I know it could benefit from being moved earlier for tab as well, but simply restoring that call here for tab fixes the issue at hand.

@mgavioli : does this make sense to you? Sorry for once again failing to consider tab in one of my layout changes, even if it was over a year ago when I was young and naive :-)

[mgavioli]

I assume this specific change (back) leave things not worse than they were before the incriminated commit fbc6761 , which is enough for me: am I right that nobody noticed the bug for a year or more? If so, it does not look a very frequent case.

About anticipating the call to adjustReadPos(), I do not have the code at hand right now; does Score::layoutChords3() deal with tabs too? If so, it might make sense to move ti there.

[MarcSabatella]

Indeed, this sets thing back to how they were a year ago for tab, which seems sensible to me. But I didn't know if you had changed things enough since then that you would suggest an alrenative.

layoutChords3() is never called for tab. It is called within layoutChords1(), but layoutChords1() returns immediately for tab without having done anything. This is the function that handles things like offsets for seconds and overlapping voices, none of which is relevant for tab. It did occur to me I could, instead of returning immediately for tab, loop through and find all chord and all notes within those chords (including grace notes) and force the Note::layout1() there, but when I saw the comment I left within Note::layout2(), I figured why not just restore how it worked before for tab.