Improve clef hiding logic and create new style menu page #20911
Conversation
There was a problem hiding this comment.
Mostly really terrific!
Just a couple of points:
- A tad bit of vertical space would be good above the section headings "Key Signatures" and "Time Signatures" in the new Styles dialog page (See the Bends page for reference)
- I encountered an issue where key signatures were being repeated on the second system in the main score, where a system break had been entered (despite the Styles setting being set to "Hide all key signatures after the first system where they appear").
Both of these issues are illustrated in this video
I also noticed a variant of issue no. 2 above when reviewing part scores: See this video
Test score used:
clefs-visibility-test-11Jan23.mscz.zip
| <property name="spacing"> | ||
| <number>0</number> | ||
| </property> |
There was a problem hiding this comment.
- A tad bit of vertical space would be good above the section headings "Key Signatures" and "Time Signatures" in the new Styles dialog page (See the Bends page for reference)
Looks like these lines would need to be removed to achieve that
| <property name="currentIndex"> | ||
| <number>1</number> | ||
| </property> |
There was a problem hiding this comment.
Preferably, drop this change
| <tabstop>genKeysig</tabstop> | ||
| <tabstop>genCourtesyClef</tabstop> | ||
| <tabstop>genCourtesyTimesig</tabstop> | ||
| <tabstop>genCourtesyKeysig</tabstop> |
There was a problem hiding this comment.
Make sure any new buttons have a sensible tab order. This can be done as follows:
-
Click this tiny button to enter tab order edit mode
-
On the previous page, look what's the last tab stop number: it's 131
-
Right-click and choose "Tab Order List"
-
Drag the new buttons from the bottom of the list to just after item 131
Schermopname.2024-01-12.om.00.19.53_.mov
-
Right-click the first item on the page and choose "start from here"
-
Click the items in the correct order. (misclicked? Use "start from here" again)
Schermopname.2024-01-12.om.00.25.23_.mov
(and yes, it can be hyper frustrating)
miiizen
force-pushed
the
20795-hide-clef
branch
from
86058d4
to
a985f0a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
miiizen
force-pushed
the
20795-hide-clef
branch
from
a985f0a
to
ab5e9c3
Compare
|
Great we're getting this one done. Thanks all! |
Resolves: #20795