Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partial fix for #46861: musicxml export lyrics extend #2098

Merged
merged 1 commit into from
Jul 11, 2015

Conversation

MarcSabatella
Copy link
Contributor

I originally assumed we lost the MusicXML export for lyrics extenders (underscore) with the fairly recent overhaul from @mgavioli . But actually, it seems this code was removed way back in 2011, here:

http://sourceforge.net/p/mscore/code/4587/

@lvinken , @wschweer : do either of you remember what this might be about? As far as I can tell, in the current code, simply checking l->ticks() works just fine to give us the same export we had in 1.3: a single "extend" element on the lyric itself. No support for the MusicXML 3.0 start/continue/stop tags, but apparently that isn't strictly necessary. I think my PR here should restore 2.0 to the same level of functionality as 1.3, unless there is something I am missing.

Getting the import to work seems it might be more difficult, but at least one user is caring more about export than import and really misses this.

@lasconic
Copy link
Contributor

lasconic commented Jul 7, 2015

I'm a bit concerned by the fact that this commit would make the import/export process asymetric since we don't import extend at all. @lvinken any thoughts?

@MarcSabatella
Copy link
Contributor Author

My concern is that at least one user developing software that relies on our MusicXML export sees this as a significant / showstopper regression from 1.3, which did export the extend tag in this way. And as far as I know, 1.3 did not import it either. See https://musescore.org/en/node/66866

I imagine we could implement a rough version of the import, not supporting the start/continute/end tags and always assuming extend means until the next lyric. I will look into this.

lasconic added a commit that referenced this pull request Jul 11, 2015
partial fix for #46861: musicxml export lyrics extend
@lasconic lasconic merged commit 2be4679 into musescore:master Jul 11, 2015
@lvinken
Copy link
Contributor

lvinken commented Jul 20, 2015

Marc,Nicolas,

sorry about not responding to your questions, but I have been on vacation and off-line for three weeks.

I have no specific recollection about disabling the extend, although many MusicXML features were broken by the big redesigns after 1.3 and repaired later. This may have been one of those.

In the near future I would like to support for the MusicXML 3.0 start/continue/stop tags and add import and regression tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants