partial fix for #46861: musicxml export lyrics extend #2098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally assumed we lost the MusicXML export for lyrics extenders (underscore) with the fairly recent overhaul from @mgavioli . But actually, it seems this code was removed way back in 2011, here:
http://sourceforge.net/p/mscore/code/4587/
@lvinken , @wschweer : do either of you remember what this might be about? As far as I can tell, in the current code, simply checking l->ticks() works just fine to give us the same export we had in 1.3: a single "extend" element on the lyric itself. No support for the MusicXML 3.0 start/continue/stop tags, but apparently that isn't strictly necessary. I think my PR here should restore 2.0 to the same level of functionality as 1.3, unless there is something I am missing.
Getting the import to work seems it might be more difficult, but at least one user is caring more about export than import and really misses this.