Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change instrument short names—Trb. to Tbn. and Vlc. to Vc. #2111

Merged
merged 2 commits into from Jul 9, 2015
Merged

Change instrument short names—Trb. to Tbn. and Vlc. to Vc. #2111

merged 2 commits into from Jul 9, 2015

Conversation

IsaacWeiss
Copy link
Contributor

Hi Thomas,

Thank you so much for giving me this opportunity. I did it! ;-)

lasconic added a commit that referenced this pull request Jul 9, 2015
Change instrument short names—Trb. to Tbn. and Vlc. to Vc.
@lasconic lasconic merged commit 1281826 into musescore:master Jul 9, 2015
@lasconic
Copy link
Contributor

lasconic commented Jul 9, 2015

Thanks for taking care of the tests failure.
Could you check your git preferences to make sure you have a good email set up for git. If not the commits will not be linked to your account. See https://help.github.com/articles/setting-your-email-in-git/
Would be good if you could add isaacweiss@r123-27-171-108.wccnet.edu and isaacweiss@Isaacs-MacBook.local as emails to your account here https://github.com/settings/emails

@IsaacWeiss
Copy link
Contributor Author

Where did those email addresses come from? I do have a wccnet.edu address, but it doesn't look like that. And the other one—@Isaacs-MacBook.local—first of all is not a real email address, and second of all suddenly makes me very uncomfortable about my privacy.

@lasconic
Copy link
Contributor

lasconic commented Jul 9, 2015

Sorry about your privacy. The two addresses were probably generated automatically on the computer where you installed the github client. I assume there is a way to set them in this client.

Also once you set them on github, you can get a private email and use this one. See https://help.github.com/articles/keeping-your-email-address-private/

@IsaacWeiss
Copy link
Contributor Author

Well, I'm doubtful that those addresses will serve any purpose, but I've done it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants