fix #41786: barline span issues after edit / instrument #2125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes both https://musescore.org/en/node/41786 and https://musescore.org/en/node/68921, as well as similar issues where barline spans are invalid in some way after edit / instruments (see, for instance, https://musescore.org/en/node/68996).
The code for this comes from my PR #2122 , which is at this point still has issues I don't know how to resolve. However, this new PR stands on its own and is usable as is.
It comes with one small regression that to me is more than worth it. I added a TODO in the code about it, and I'll add a line comment there with more info.