Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #41786: barline span issues after edit / instrument #2125

Merged
merged 1 commit into from Jul 15, 2015

Conversation

MarcSabatella
Copy link
Contributor

This fixes both https://musescore.org/en/node/41786 and https://musescore.org/en/node/68921, as well as similar issues where barline spans are invalid in some way after edit / instruments (see, for instance, https://musescore.org/en/node/68996).

The code for this comes from my PR #2122 , which is at this point still has issues I don't know how to resolve. However, this new PR stands on its own and is usable as is.

It comes with one small regression that to me is more than worth it. I added a TODO in the code about it, and I'll add a line comment there with more info.

setSpan = n - i;
}
else if (span > 1 && staff->barLineTo() > 0) {
// TODO: check if span is still valid
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, here is the regression:

If you have a barline span of more than staff and it ends somewhere in the middle of the last staff, this customization will be lost if you make changes in Edit / Instruments. The barline will be reset to end at the bottom of the staff as it normally would. Workround: you can then restore the customized span and it will work fine.

I judge this to be not worth worrying about. Barlines spans of a single staff that end in the middle of a staff are common enough (eg, "tick" barlines), as are barlines spans of multiple staves that end above the last staff ("Mensurstrich"). I was able to make these cases work. I don't know of a use case for barline spans of multiple staves that end in the middle of a staff. I'm sure there is one, but if that is the only thing that gets messed up on Edit / Instruments, I would gladly accept that for now in order to fix the more common & more serious problems that this PR addresses.

lasconic added a commit that referenced this pull request Jul 15, 2015
fix #41786: barline span issues after edit / instrument
@lasconic lasconic merged commit 70e7bbe into musescore:master Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants