Album::createScore now tries to append all excerpts (parts) for each score. #2138
Conversation
| firstScore->doLayout(); | ||
| for (int i=0; i<firstScore->excerpts().count(); i++) { |
There was a problem hiding this comment.
Could you fix the spaces here?
for (int i = 0; i < firstScore->excerpts().count(); i++)
|
I think I fixed spacing. I did go through https://musescore.org/en/developers-handbook/musescore-coding-rules again, but I didn't see an explicitly stated rule about putting one space before and after operators in expressions, nor an explicitly stated rule about not putting a space immediately after opening parenthesis and immediately before closing parenthesis, although the example code does follow those rules implicitly. Maybe you should add those rules explicitly? |
|
I edited the coding rules page to reflect what I think these rules are, but please verify that I wrote them correctly: https://musescore.org/en/developers-handbook/musescore-coding-rules#Binary-Operators |
|
Perfect! Thank you for editing the guidelines! |
Album::createScore now tries to append all excerpts (parts) for each score.
If want to create joined mscz of an album of scores that all already contain pregenerated parts (called "excerpts" interally), then this fixes bug #70836 where only part excerpts from the first score are copied to joined score. Album::createScore now iterates over every part excerpt for every album item and appends it to the corresponding part excerpt of the joined score. That means that any part specific edits (e.g. part-specific spacings) are now copied over to the joined score. Note: for simplicity sake, I am assuming user has identical ordering of parts in each score. I am only testing to make sure that there are an equal number of part excerpts in each score and am testing that each part excerpt actually exists before trying to append, or else I display a meaningful qDebug message, and return failure so that the user gets presented with error popup. Any more testing (e.g. that the parts are named the same, use the same instruments, and have the same number of staves, etc.) I think is beyond of the scope of this bug as it would have made this fix much more complicated.