Key-based cursor note movement and pitch2tpc() #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace pitch2tpc2() and both variants of pitch2tpc() with a single generic pitch2tpc(). Add PREFER_SHARPS, PREFER_NEAREST and PREFER_FLATS. Update all places where those functions are called from. Use intelligent key-aware stepping of pitch and tpc in Score::upDown().
wschweer
added a commit
that referenced
this pull request
Feb 25, 2013
Key-based cursor note movement and pitch2tpc()
heuchi
pushed a commit
to heuchi/MuseScore
that referenced
this pull request
Nov 13, 2013
Key-based cursor note movement and pitch2tpc()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace pitch2tpc2() and both variants of pitch2tpc() with a single
generic pitch2tpc(). Add PREFER_SHARPS, PREFER_NEAREST and PREFER_FLATS.
Update all places where those functions are called from.
Use intelligent key-aware stepping of pitch and tpc in Score::upDown().