Some more small adjustments for empty strings #21474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #21445 (comment) ff. |
| @@ -2014,12 +2014,12 @@ void ExportMusicXml::barlineRight(const Measure* const m, const track_idx_t stra | |||
| // note: use barlinetype as found in multi measure rest for last measure of replaced sequence | |||
| BarLineType bst = m == mmRLst ? mmR1->endBarLineType() : m->endBarLineType(); | |||
| const bool visible = m->endBarLineVisible(); | |||
| String color = u""; | |||
| String color = String(); | |||
There was a problem hiding this comment.
better just String color;
igorkorsukov
approved these changes
Feb 12, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 13, 2024
Backport of musescore#21474 (and some more)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 13, 2024
Backport of musescore#21474 (and some more)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 13, 2024
Backport of musescore#21474 (and some more) Co-authored-by: Klaus Rettinghaus <klaus.rettinghaus@gmail.com>
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 9, 2024
Backport of musescore#21474 (and some more) Co-authored-by: Klaus Rettinghaus <klaus.rettinghaus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.