Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for arm, where char by default is unsigned #2171

Merged
merged 1 commit into from
Aug 27, 2015

Conversation

Jojo-Schmitz
Copy link
Contributor

@lasconic
Copy link
Contributor

is that tested?

@Jojo-Schmitz
Copy link
Contributor Author

Not on arm, not by me, it is just obviously correct ;-)
I'm quite puzzled that other platforms like Mac or Linux don't complain about this?

@ericfont
Copy link
Contributor

I will try to test in the next week or so...will likely be more bugs when try to compile for arch linux arm. But I do have at least one of each armv5, armv6, armv7 to test on.

@ericfont
Copy link
Contributor

My suspicion is that since the official archlinuxarm build failed 20% the way through, there will likely be some more compiler errors during the rest. Probably will be even more of the signed issues.

@lasconic
Copy link
Contributor

As far as I know, it runs on debian arm. See at the bottom here https://packages.debian.org/sid/musescore

@ericfont
Copy link
Contributor

it is possible that because arch linux always uses the latest stuff version, that the newer compiler complains, while older ones used by debian don't complain. So they issue might affect debian later. Or it could be a build script issue.

Anyway, these data types should always be the most unambiguous for maximum portability.

lasconic added a commit that referenced this pull request Aug 27, 2015
fix for arm, where char by default is unsigned
@lasconic lasconic merged commit a918b7f into musescore:master Aug 27, 2015
@Jojo-Schmitz Jojo-Schmitz deleted the signed-char-for-arm branch August 27, 2015 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants