Add more dynamics, namely sfff and sfffz #21827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
more-dynamics
branch
from
210b89e
to
8b6ddef
Compare
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2024
See https://musescore.org/en/node/359923#comment-1231431, https://musescore.org/en/node/92826#comment-1231428 and https://musescore.org/en/node/11888 'Backport' of musescore#21827 (actually this here existed first)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2024
See https://musescore.org/en/node/359923#comment-1231431, https://musescore.org/en/node/92826#comment-1231428 and https://musescore.org/en/node/11888 'Backport' of musescore#21827 (actually this here existed first)
rettinghaus
approved these changes
Mar 5, 2024
|
Could this one get reviewed please? |
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 19, 2024
See https://musescore.org/en/node/359923#comment-1231431, https://musescore.org/en/node/92826#comment-1231428 and https://musescore.org/en/node/11888 'Backport' of musescore#21827 (actually this here existed first)
8 tasks
Jojo-Schmitz
force-pushed
the
more-dynamics
branch
2 times, most recently
from
bd222ca
to
b97d4c7
Compare
|
Needs formatting and also tests fail. |
Jojo-Schmitz
force-pushed
the
more-dynamics
branch
2 times, most recently
from
f28a289
to
f2f1942
Compare
Fixed |
|
Opcodes are in the dynamics / UI 
|
Jojo-Schmitz
commented
Jun 17, 2024
Jojo-Schmitz
force-pushed
the
more-dynamics
branch
from
f2f1942
to
0a8b0e9
Compare
|
Please rebase (there was an issue with Windows builds, should be fixed now) |
Jojo-Schmitz
force-pushed
the
more-dynamics
branch
from
0a8b0e9
to
c0b6c4c
Compare
|
done |
|
Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved (once merged, sfff and sfffz will need to be added to this issue: #14736 ) |
|
Did you forget to mark it as approved? |
RomanPudashkin
approved these changes
Jun 19, 2024
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jun 19, 2024
See https://musescore.org/en/node/359923#comment-1231431, https://musescore.org/en/node/92826#comment-1231428 and https://musescore.org/en/node/11888 'Backport' of musescore#21827 (actually this here existed first)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/359923#comment-1231431, https://musescore.org/en/node/92826#comment-1231428 and https://musescore.org/en/node/11888