Fix spanner disappearing from closed parts

[mike-spa]

Resolves: #21286 Specifically, the cases reproduced in this comment, and this comment.
Resolves: #19852 (and hopefully many other similar issues reported without clear steps for reproducing)

It seems that the whole problem (for hairpins and other lines) was caused by an error in reading part scores with multi measure rests. This error was masked in previous version because it gets corrected during layout, but since 4.0 we do not layout closed parts to avoid waste of performance, so the error came up. As far as I can tell, this seems to fix it.

The problem with slurs was more involved (and also used to be masked in previous versions for the same reasons).

[mercuree]

Not sure if it also was supposed to fix slurs reproduced in this comment.
Just pointing out that that problem with slurs isn't solved by this PR.

[mercuree]

Great job!
I found more cases though. Is this already abuse? Should I stop?

1. Hairpin lost if you extend it manually

hairpin_lost2.mp4

2. If you double duration. I don’t know why this might be needed, but it’s worth mentioning

slur_lost_strange_case.mp4

[mike-spa]

I found more cases though. Is this already abuse? Should I stop?

Actually we must thank you, you're the first who's managed to reproduce these bugs (hence why we couldn't fix them before despite being reported for a while). I'll look into those last ones too

[mercuree]

Thank you for your efforts! I think next case shouldn't be covered by this PR. Maybe I need to create separate issue with low priority because "join measures" function looks exotic to me.

join_measure_slurs_lost.mp4

One last thing just to be sure everything is right.
This #21418 PR for lost grace note slurs accidently fixes similar case for regular slurs too.
It affects only one file src/engraving/rw/read410/connectorinforeader.cpp
But I found the same code in /src/engraving/rw/read400/connectorinforeader.cpp
Does it matter or this just dead code I shouldn't worry about?

[mike-spa]

Maybe I need to create separate issue with low priority because "join measures" function looks exotic to me.

Yes, the slur disappears also in the score, so this is an entirely different issue.

Does it matter

No, pretty sure it doesn't

[mercuree]

Something wrong with voices

hairpin_lost_voices.mp4

[mike-spa]

Something wrong with voices

Can't reproduce this one. It works fine for me in this branch.

[DmitryArefiev]

To repro it's important how the hairpin is added (to which voice)

bandicam.2024-03-13.11-13-35-171.mp4

(occurs in master as well)

[mike-spa]

Changed a few things, fixed unit tests. Please give it another round :)

[mercuree]

I have a case where I don't understand what's going on and not sure if it's related to this PR.
There is a score Disappearing elements.mscz which I investigated for hairpin loss.
Staff 1, measure 26. There is hairpin "cresc. poco a poco". It's lost in Bass trombone part, but this is expected, so I do Parts reset for Bass Trombone. Hairpin reappears, but will not survive save/reopen in both main score and part.
Actually, it will also not survive save/reopen without parts reset.

Other case: Staff 1, measure 244-245. Hairpin there will also not survive save/reopen.

If the problem is in broken score itself, maybe it's not worth it to fix it at the cost of complicating the code

[mike-spa]

I have a case where I don't understand what's going on and not sure if it's related to this PR. There is a score Disappearing elements.mscz which I investigated for hairpin loss. Staff 1, measure 26. There is hairpin "cresc. poco a poco". It's lost in Bass trombone part, but this is expected, so I do Parts reset for Bass Trombone. Hairpin reappears, but will not survive save/reopen in both main score and part. Actually, it will also not survive save/reopen without parts reset.

This (and you don't know I happy it makes me to say this) is fixed in #21633 😍

[DmitryArefiev]

Tested the cases reproduced in #21286 (comment), #21286 (comment) and #21883 (comment) on Win10/Mac13.6. FIXED

[mercuree]

If you are planning to merge this with 4.3.0 branch, please consider adding #21418 too, because it also fixes some cases for grace and regular slurs. Thank you!

[DmitryArefiev]

I have a case where I don't understand what's going on and not sure if it's related to this PR. There is a score Disappearing elements.mscz which I investigated for hairpin loss. Staff 1, measure 26. There is hairpin "cresc. poco a poco". It's lost in Bass trombone part, but this is expected, so I do Parts reset for Bass Trombone. Hairpin reappears, but will not survive save/reopen in both main score and part. Actually, it will also not survive save/reopen without parts reset.

This (and you don't know I happy it makes me to say this) is fixed in #21633 😍

@mike-spa I've tried the last build from #21633 (on Win10). That issue is fixed for Bass trombone but still happens with Euphonium

bandicam.2024-03-21.15-35-24-283.mp4