Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swedish (modern) & Swedish (traditional) translations #22005

Merged
merged 3 commits into from
Mar 30, 2024

Conversation

shoogle
Copy link
Contributor

@shoogle shoogle commented Mar 21, 2024

There was disagreement among Swedish translators over whether to use modern or traditional terms in the Swedish [sv] translation. To resolve this, I've created a new language for the traditional terms, and updated the names of both languages in Preferences to distinguish between them.

Code Transifex name Preferences name Comment
sv Swedish Svenska (modern) Our existing Swedish translation
sv_SE Swedish (Sweden) Svenska (traditionell) The new translation

There isn't a language code for "Swedish (traditional)", hence sv_SE is used instead.

The existing translation was copied and then edited to create the new translation. See second commit for the strings that have changed.

@shoogle shoogle changed the title Swedish traditional Swedish (modern) & Swedish (traditional) translations Mar 21, 2024
@cbjeukendrup
Copy link
Contributor

We should think about which consequences this has for automatic language selection based on system language code (see LanguagesService::effectiveLanguageCode).
With this PR, users whose system language code returns sv would get the modern variant, and users with sv_SE would get the traditional variant, but we might want to redirect both to the modern variant by default (for example).

@shoogle
Copy link
Contributor Author

shoogle commented Mar 26, 2024

@cbjeukendrup, good point. I've updated the PR to prefer the modern translations when using the system locale. Users would have to choose the traditional ones explicitly, if that's what they want to use.

I confirmed it shows the modern translations on Windows when the system locale is Swedish (Sweden), and that the traditional translations are shown if they are manually selected via Preferences.

shoogle referenced this pull request Mar 28, 2024
Ensure users get the modern translations regardless of whether the
system locale is Swedish [sv] or Swedish (Sweden) [sv_SE].

If the user wants to see traditional translations they must choose this
explicity in Preferences rather than relying on the system language.
Ensure users get the modern translations regardless of whether the
system locale is Swedish [sv] or Swedish (Sweden) [sv_SE].

If the user wants to see traditional translations they must choose this
explicity in Preferences rather than relying on the system language.
@shoogle shoogle merged commit 72ce37d into musescore:master Mar 30, 2024
11 checks passed
@shoogle shoogle deleted the swedish-traditional branch March 30, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants