change "bar line" to "barline" #2216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
barline
branch
from
a0bb469
to
c00d5b2
Compare
While both seems correct, we should be consistent about it. See also https://musescore.org/en/node/77186, Marc had settled for "barline" in his book and except for some debug statements we're pretty consistently using 'barline' in MuseScore source too, just one user visible deviation in libmscore/element.cpp. While at it, also change "End bar barline" to "Final barline".
Jojo-Schmitz
force-pushed
the
barline
branch
from
c00d5b2
to
dcd18a0
Compare
lasconic
added a commit
that referenced
this pull request
Sep 14, 2015
change "bar line" to "barline"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While both seems correct, we should be consistent about it.
See also https://musescore.org/en/node/77186, Marc had settled for
"barline" in his book and except for some debug statements we're pretty
consistently using 'barline' in MuseScore source too, just one user
visible deviation in libmscore/element.cpp.
While at it, also change "End bar barline" to "Final barline".