fix #81456: timesig paste fails #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschweer
added a commit
that referenced
this pull request
Oct 27, 2015
fix #81456: timesig paste fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "pos" parameter in the drop fucntions is set differently depending on how the drop was invoked, and I'm kind of figuring this out as I go along. Code I added a while ago to allow adding time signatures by double click was working well enough, but the same code is used to handle copy/paste of time signature. This copy/paste formerly happened to work soemtimes, depending on the value of an uninitiatized variable, but would crash in other situations in 2.0.2. Turns out my PR #2207 - already merged - fixed that crash, but also prevented the paste from working in the cases where it otherwiuse might have happened to.
My change here should fix this case to allow paste to work, and should also be safe for any other code paths that result in ChordRest::drop() being called to add a time signature.