update tinyxml to version 10 #22475
Merged
update tinyxml to version 10 #22475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to introduce a new |
| @@ -23,9 +23,7 @@ distribution. | |||
|
|
|||
| #include "tinyxml2.h" | |||
|
|
|||
| #include "mu_patch.h" | |||
There was a problem hiding this comment.
This seems to indicate that we patched it at some point. See d6a5864. We should check if that patch is still needed.
There was a problem hiding this comment.
I think this is the reason for the failing tests. I added the line again.
There was a problem hiding this comment.
But note that it's not only that line, that's why I mentioned d6a5864
igorkorsukov
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update to tinyxml, see https://github.com/leethomason/tinyxml2/releases/tag/10.0.0