Read 'print-object' for directions and write for tempo #22577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4855,6 +4855,9 @@ static void wordsMetronome(XmlWriter& xml, const MStyle& s, TextBase const* cons | |||
| String tagName = String(u"metronome parentheses=\"%1\"").arg(hasParen ? u"yes" : u"no"); | |||
| tagName += color2xml(text); | |||
| tagName += ExportMusicXml::positioningAttributes(text); | |||
| if (!text->visible()) { | |||
| tagName += u"print-object=\"no\""; | |||
There was a problem hiding this comment.
a leading space is missing there, should be
tagName += u" print-object=\"no\"";
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 26, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 26, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 26, 2024
| </attributes> | ||
| <direction placement="above"> | ||
| <direction-type> | ||
| <metronome parentheses="no"print-object="no"> |
miiizen
force-pushed
the
xml-direction-visibility
branch
from
52e4085
to
0b5d32a
Compare
oktophonie
approved these changes
Apr 26, 2024
RomanPudashkin
approved these changes
Apr 26, 2024
miiizen
force-pushed
the
xml-direction-visibility
branch
from
0b5d32a
to
205c127
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 6, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 14, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 24, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 27, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 27, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 27, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reads the
print-objecttag for<direction>elements. It also writes this tag when exporting tempo text as metronome markings.