Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license headers #22680

Merged
merged 2 commits into from
May 5, 2024
Merged

Conversation

BrownianNotion
Copy link
Contributor

@BrownianNotion BrownianNotion commented May 4, 2024

Resolves: #18710

Updated license headers. Wasn't sure about copyright year so I defaulted to 2024. Note that some files not listed in the original issue (eg. sandbox/engraving/log.h) have the correct license but an old copyright year.

TODO:

  • Remove === lines and replace // comments with /**/
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with more recently added files, I suggest two things:

  • remove those ===================================================================== lines
  • In engraving/sandbox.h and tools/bww2html/mxmlwriter.h, use /* */ comments (like for example in src/app/main.cpp) instead of //.
    (This is useful because some IDEs recognise copyright comments at the top of a file, and when it's a /* */ comment it is collapsed automatically.)

@BrownianNotion
Copy link
Contributor Author

For consistency with more recently added files, I suggest two things:

  • remove those ===================================================================== lines
  • In engraving/sandbox.h and tools/bww2html/mxmlwriter.h, use /* */ comments (like for example in src/app/main.cpp) instead of //.
    (This is useful because some IDEs recognise copyright comments at the top of a file, and when it's a /* */ comment it is collapsed automatically.)

Changed! Have left the === lines in the .xml files to be consistent with the rest of the file.

Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks good!

@cbjeukendrup
Copy link
Contributor

One more question: what username on MuseScore.org did you use to sign the CLA?

@BrownianNotion
Copy link
Contributor Author

One more question: what username on MuseScore.org did you use to sign the CLA?

Username was andrewwusyd (my bio has a url to this github :) ).

@cbjeukendrup cbjeukendrup merged commit dc7a8f7 into musescore:master May 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect FSF address
2 participants