Fix crash when opening score where TAB clefs are not shown #22802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanPudashkin
approved these changes
May 13, 2024
miiizen
approved these changes
May 13, 2024
|
(Another correct way would have been: if (Measure* prevMeas = searchMeasure->prevMeasure(); prevMeas && !clefSeg) {But let's avoid these "if statements with initialisation" as much as possible, since not everyone might know exactly what they are and how they work and they don't make the code much nicer.) |
|
Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #22759
@miiizen Is this what you intended?
(
;withinifis tricky: the thing at the left of the;is not an expression but a statement, and thus not checked for truth.)