Fix #88171 - Lyrics dash max distance as a parameter #2294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns the previously hard-code max. distance between multiple dashes into a user configurable score style. __References__: - Issue: https://musescore.org/en/node/88171 - Original request with discussion and screen-shots: https://musescore.org/en/node/87841
|
seems a rebase is needed |
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 15, 2016
Turns the previously hard-coded max. distance between multiple dashes into a user configurable score style. __References__: - Issue: https://musescore.org/en/node/88171 - Original request with discussion and screen-shots: https://musescore.org/en/node/87841 Shamelessly stolen from PR musescore#2294, which needed a non-trivial rebase
|
I had a go at a rebase, see #2785, hope you don't mind me stealing your code? |
|
OK, so now this PR is no longer needed and should get closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #88171 - Lyrics dash max distance as a parameter
Turns the previously hard-code max. distance between multiple dashes into a user configurable score style.
References: