Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat NumPad Enter the same as Return #23160

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Jun 10, 2024

@Jojo-Schmitz
Copy link
Contributor Author

Any special reason why shortcuts_AZERTY.xml is missing an entry for <key>add-lyric-verse</key>? Should I add it?

@RomanPudashkin RomanPudashkin requested a review from Eism June 12, 2024 07:29
@Jojo-Schmitz
Copy link
Contributor Author

Would someone mind to review this?

@zacjansheski
Copy link
Contributor

Is this confirmed to work?

I don't get any change using NumPad Enter (Neither Num Lock on or off)

Windows 11 QWERTY

(num pad enter works as expected when writing text)

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Jul 1, 2024

That's not using the shortcut ;-)

One way to test: select a measure or barline, press Return. Then try the same with Enter
With the fix both should add a system break, without on the Return
Ctrl+Return and Ctrl+Enter should add pages breaks
On lyrics both Return and Enter should add another verse.

@zacjansheski
Copy link
Contributor

I did a factory reset and now the numpad enter works and regular enter does not

https://drive.google.com/file/d/107IPhRuh9hFVIT_RcBdFBTs1N-RHrpB-/view?usp=sharing

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Jul 2, 2024

Looking into that...
What does the shortcuts dialog show when searching for Return and/or Enter?
Should look like this:
image

Asking because it does work for me, even after a factory reset

While at it, I rebased it

@zacjansheski
Copy link
Contributor

zacjansheski commented Jul 2, 2024

This is what I have after factory reset

Notice:
Add/remove page break = Ctrl+Return
Add/remove system break = Enter

Screenshot 2024-07-02 114856

Add lyric verse = Return

Screenshot 2024-07-02 115053

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Jul 2, 2024

Not for me. Windows 11, German QWERTZ keyboard, I tried several times, Factory reset, Reset preferences and also removing C:\Users\Jojo\AppData\Local\MuseScore}MuseScore4Development.
For the screenshot above I only switched the language to English (US)

@zacjansheski
Copy link
Contributor

Well, I'm not sure what was going on there but after another restart and reset everything seems in order on my Windows device, my apologies

@zacjansheski
Copy link
Contributor

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved

@Eism Eism merged commit 9433893 into musescore:master Jul 3, 2024
11 checks passed
@Jojo-Schmitz Jojo-Schmitz deleted the numpad branch July 3, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants