Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#fix 90891: corrected references to first and last segment #2319

Merged

Conversation

jeetee
Copy link
Contributor

@jeetee jeetee commented Dec 20, 2015

for QML definition

@Jojo-Schmitz
Copy link
Contributor

I wonder how existing plugins using lastSegment and firstSegment are reacting on that change, namely notenames.qml, colornotes.qml and walk,gml. They still seem to work, but I wonder why? Maybe they now step from start to end rather then from end to start?

@jeetee
Copy link
Contributor Author

jeetee commented Dec 20, 2015

**notenames.qml* (L:138) uses the lastSegment from curScore (which is a Ms::Score, not Ms::Measure) as QML link, which uses the underlying C++ call to Ms::Measure::last, not the QML-reference fixed here.
colornotes.qml uses the same logic as for notenames.qml
walk.qml likewise uses firstSegment from curScore which is linked to the C++ call in Ms::Score, which in turn uses the correct underlying C++ call to Ms::Measure::first, instead of the broken QML-reference from Ms::Measure

So these all work and are unaffected by this patch.

@Jojo-Schmitz
Copy link
Contributor

Ah, interesting. Thanks for checking.

wschweer added a commit that referenced this pull request Jan 4, 2016
…ment

#fix 90891: corrected references to first and last segment
@wschweer wschweer merged commit bdeca3e into musescore:master Jan 4, 2016
@jeetee jeetee deleted the 90891-QML-measure-first-last-segment branch January 4, 2016 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants