Fix more anchors-related issues #23190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
force-pushed
the
fixEndOfDurationBugs
branch
2 times, most recently
from
dcf8d9b
to
018ef39
Compare
oktophonie
approved these changes
Jun 12, 2024
mike-spa
force-pushed
the
fixEndOfDurationBugs
branch
from
018ef39
to
5c0be1b
Compare
mike-spa
force-pushed
the
fixEndOfDurationBugs
branch
from
5c0be1b
to
1ed6794
Compare
- Find the correct measure in the linked score - Ensure that the same TimeTickAnchor is always created in every part - Correct dynamic copy constructor
mike-spa
force-pushed
the
fixEndOfDurationBugs
branch
from
06059ec
to
b41409f
Compare
RomanPudashkin
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #22880
Resolves: #23185
Resolves: #23206
Resolves: #23209
A couple of noteworthy changes:
When two segments are at the same tick (i.e. happen at the same time), we establish which one goes before from the order of this enumeration. Given that the TimeTick segment isn't really an engraving thing but an invisible ruler, the choice of putting it before or after the other segments seemed just a matter of convention, so I originally put it last. From working on these issues thoguh I've realized that the more convenient choice is to put it before ChordRest type. This simplifies several things downstream.
I've also realized that it makes sense for Segment::allElementsInvisible to always return true for TimeTick segments, because from an engraving point of view anchors are always invisible. This also simplifies a few things downstream.