Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #93006: layout shift due to overestimating size of courtesy keysig #2361

Merged
merged 1 commit into from
Jan 27, 2016

Conversation

MarcSabatella
Copy link
Contributor

Last year we (mostly @mgavioli ) fixed a number of issues that were causing inconsistencies in layout, with a typical symptom being that each time you pressed Ctrl+A, one measure would move back and forth from one system to the next, with a correspond ripple effect on layout from that point on. These issues all had to do with how we accounted for the width of courtesy elements - clefs, key and time signatures.

In the process of fixing these, I introduced some code that almost but not quite worked:

25e43f2

It works well if there is only one staff, but the more staves, the more the code overestimates the width of courtesy key signatures, because I keep adding leftMargin to the accumulated max width on every iteration of the loop rather than only adding it to the current width. So the more staves a piece has, the more we overestimate the width of courtesy elements, leading us to think a measure will fit that won't or vice versa.

lasconic added a commit that referenced this pull request Jan 27, 2016
fix #93006: layout shift due to overestimating size of courtesy keysig
@lasconic lasconic merged commit 5de0299 into musescore:master Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants