fix #22622: Partial fix, export barlines subtypes

[akhisud]

This fixes it partially. It exports the barline styles correclty- i.e, double, dotted, dashed etc but doesn't handle staffs spanned.

[Jojo-Schmitz]

whitespace damage

[Jojo-Schmitz]

Travis failed and seemling for good reasons, in mtest for tst_midimapping. Either the tests need to get adjusted or the code, I'm not sure which

[Jojo-Schmitz]

Why? You could have fixed the issues instead?

[akhisud]

I'll fix them and reopen the PR

[Jojo-Schmitz]

OK, but you could also without closing the PR.

[akhisud]

Is there a lint code that I could just run on my program so that it fixes spaces etc according to the rules for MuseScore coding?

[akhisud]

I have a feeling there's a problem with the tests that are making the checks fail: https://travis-ci.org/musescore/MuseScore/jobs/118911893. I think travis has a wrong (old?) version of the reference files for which it is failing. It says some lines should be there and some not, which is not the case in the reference test files in the current repo. Can this be confirmed?
Namely, these files: https://github.com/musescore/MuseScore/blob/master/test/musicxml/testMultiMeasureRest1_ref.xml
https://github.com/musescore/MuseScore/blob/master/test/musicxml/testMultiMeasureRest2_ref.xml
https://github.com/musescore/MuseScore/blob/master/test/musicxml/testMultiMeasureRest3_ref.xml

[Jojo-Schmitz]

See https://musescore.org/en/developers-handbook/musescore-coding-rules there's a settings file for QtCreator that takes care of the coding style
@lvinken would be the guy to do a tech review it is for sure not tracks that has old versions, but GitHub repository,

[lvinken]

Sorry, but the auto test on Travis is correct and your changes really do not pass: testMultiMeasureRest3 fails and testSystemBrackets1 segfaults.

Please verify the auto test runs OK before submitting a pull request.
Tip: on Unix run "(cd mtest/musicxml/io/; ./iotest)" at the top-level of the source tree.

[akhisud]

The latest build on my travis (https://travis-ci.org/akhisud/MuseScore/jobs/119016323) gives this:

46/46 Test #41: tst_mxml_io ......................***Exception: Other 11.80 sec

as the only problematic part. What does this mean?

[Jojo-Schmitz]

I guess that is the segvailt @lvinken talked about

[akhisud]

I don't think it is. I was able to resolve the segfault that it threw out. When there were failures it gave me the test case on which it failed, but it doesn't in this case

[akhisud]

The following tests FAILED:
41 - tst_mxml_io (OTHER_FAULT).

[Jojo-Schmitz]

It could also be a temp glitch on Travis and pass on next attempt

[AntonioBL]

The first failing test is TestMxmlIO::systemBrackets1(), related to file testSystemBrackets1.xml in the mtest\musicxml\io folder.
Attached the backtrace for this test. Apparently, a null element is being accessed as the result of retrieving track 4 element from lastSegment (which only has a bar line at track 0).
backtrace.txt

[akhisud]

@AntonioBL, thanks, that was the problem after all! Could you tell me how you identified this particular file as giving the problem? I could only see tst_mxml_io.

[Jojo-Schmitz]

to be continued in #2503

[AntonioBL]

@akhisud : well, I simply run the tests locally and inside gdb, just to be sure to catch the error, i.e (assuming a Linux OS):
cd MuseScore
make debug (to compile MuseScore as a debug build)
cd build.debug/mtest/musicxml/io (to compile MusicXML I/O tests)
make
gdb ./tst_mxml_io
(and then "run")

Ciao,
ABL

[akhisud]

@AntonioBL , Thanks for the tip and the debug :)