fix #105666: add support for Croatian instruments (Tambura) #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As instrumentsxml.h is never touched by a C/C++ compiler, 8-bit ASCII and UTF-8 characters should never cause any kind of comapitibilty or standards compliance problems, and actually never had so far with at least the ♭ being used in multiple places, so we can as well have ü, č and Č there too. So fix Güiro in other places too, in C++ code in a C++11 compatible manner. While at it fix some duplicate short instrument names and also a fix/workaround for an lupdate diagnostic
|
Replaces #2533, which got closed by accident(?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As instrumentsxml.h is never touched by a C/C++ compiler, 8-bit ASCII and UTF-8 characters should never cause any kind of comapitibilty or standards compliance problems, and actually never had so far with at
least the ♭ being used in multiple places, so we can as well have ü, č and Č there too.
So fix Güiro in other places too, in C++ code in a C++11 compatible manner.
While at it fix some duplicate short instrument names and also a fix/workaround for an lupdate diagnostic