Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #16506 Former key signature isn't restored after Undo Transpose #264

Closed
wants to merge 2,640 commits into from

Conversation

heuchi
Copy link
Contributor

@heuchi heuchi commented Mar 15, 2013

When transposing key signatures Score::transposeKeys() updates the keymap in transpose.cpp:417
(*km)[tick] = nKey;
This is not stored in the undo stack.

While undo resets the actual KeySigs, layout will later change them back to match the (old) keymap.
I added a call to setKey() in ChangeKeySig::flip() to make sure the keymap matches all key signature changes.

@heuchi
Copy link
Contributor Author

heuchi commented Mar 25, 2013

added test mtest/libmscore/transpose/tst_transpose.cpp:
transpose test score major second up, compare to reference, undo transpose, compare to original file.

wschweer and others added 29 commits September 25, 2013 11:13
A button to show closed MIDI import panel
Fixed by adding a TAB-specific shortcut similar to "rest" (def. '0').

Its default shortcut has been tentatively assigned to ' (apostrophe)
…_be_entered_in_TABs

Fix musescore#22870 - No shortcut available to enter rests in TAB's
@Jojo-Schmitz
Copy link
Contributor

as per #16506 this has been fixed, so this PR can get closed, can't it?

@heuchi
Copy link
Contributor Author

heuchi commented Nov 13, 2013

I don't see this is fixed. See new issue #23525

@heuchi
Copy link
Contributor Author

heuchi commented Nov 13, 2013

I rebased this from current master. It's addressing issues 23525, 21234 and 22913.

@lasconic
Copy link
Contributor

Thank you for the rebase! Do you mind if I apply the patch instead of merging? The history mentions 2 "users" heuchi and Joern Eichler and I would like to keep the history as clean as possible. You could also make a new PR if you prefer.

@heuchi
Copy link
Contributor Author

heuchi commented Nov 13, 2013

I just saw this and am trying to solve it using a git filter-branch. If that's not a good idea, please tell me. I seem to not having set up correctly my git system here.

@heuchi
Copy link
Contributor Author

heuchi commented Nov 13, 2013

OK, this went wrong... I'll create a new PR.

@heuchi heuchi closed this Nov 13, 2013
@lasconic
Copy link
Contributor

I have no experience with git filter-branch but it looks like a weapon of mass destruction :)

@heuchi
Copy link
Contributor Author

heuchi commented Nov 13, 2013

New PR: #540

@heuchi heuchi deleted the 16506_transpose_undo_keysig branch November 13, 2013 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet