-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #16506 Former key signature isn't restored after Undo Transpose #264
Conversation
added test mtest/libmscore/transpose/tst_transpose.cpp: |
…iations on mac, add gp, scx...
A button to show closed MIDI import panel
Fixed by adding a TAB-specific shortcut similar to "rest" (def. '0'). Its default shortcut has been tentatively assigned to ' (apostrophe)
…_be_entered_in_TABs Fix musescore#22870 - No shortcut available to enter rests in TAB's
Charset selection for MIDI import
Don't translate font name "Bravura"
The closing tag of the previous element was not read.
as per #16506 this has been fixed, so this PR can get closed, can't it? |
I don't see this is fixed. See new issue #23525 |
…iith_images Fix #23521 : reading a workspace containing <file> tags crashes
Translation of the MIDI import panel
I rebased this from current master. It's addressing issues 23525, 21234 and 22913. |
Thank you for the rebase! Do you mind if I apply the patch instead of merging? The history mentions 2 "users" heuchi and Joern Eichler and I would like to keep the history as clean as possible. You could also make a new PR if you prefer. |
I just saw this and am trying to solve it using a git filter-branch. If that's not a good idea, please tell me. I seem to not having set up correctly my git system here. |
OK, this went wrong... I'll create a new PR. |
I have no experience with git filter-branch but it looks like a weapon of mass destruction :) |
New PR: #540 |
When transposing key signatures Score::transposeKeys() updates the keymap in transpose.cpp:417
(*km)[tick] = nKey;
This is not stored in the undo stack.
While undo resets the actual KeySigs, layout will later change them back to match the (old) keymap.
I added a call to setKey() in ChangeKeySig::flip() to make sure the keymap matches all key signature changes.