Single Note Crescendo #2655
Closed
Single Note Crescendo #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CC11 for all chords if using expression
…hat advanced midi controlls
| <item row="2" column="2"> | ||
| <widget class="QToolButton" name="resetHairpinSingleNote"> | ||
| <property name="text"> | ||
| <string>...</string> |
There was a problem hiding this comment.
please add a notr="true" here
There was a problem hiding this comment.
also check the 'accessible name' for the reset button, compare with the others to see what I mean
| <string>Reset value</string> | ||
| </property> | ||
| <property name="accessibleName"> | ||
| <string>Reset playing hairpin on single notes</string> |
There was a problem hiding this comment.
Good, almost... Please make it Reset 'Play hairpin on single notes' value to make it consistent with the others (a recent change)
| @@ -338,6 +339,7 @@ static void collectMeasureEvents(EventMap* events, Measure* m, Staff* staff, int | |||
|
|
|||
| for (Segment* seg = m->first(st); seg; seg = seg->next(st)) { | |||
| int tick = seg->tick(); | |||
| int tick2 = seg->tick()+seg->ticks()-1; | |||
There was a problem hiding this comment.
adding spaces around + and - please
…score or other instruments) - fixes random segfault during instrumentchange
|
@hpfmn, with a rebase, would this pull request be ready for a review? |
|
I agree. Let's close this one for now. So it's clearer for everyone. Ok? |
|
yep - thx |
jthistle
added a commit
to jthistle/MuseScore
that referenced
this pull request
Dec 11, 2018
jthistle
pushed a commit
to jthistle/MuseScore
that referenced
this pull request
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements single note crescendo
(fixes #5178 and probably others)
this is work in progress, once everything is good I'll squash the commits together