Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #116156: buttons don't render properly on HDPI screens #2688

Merged
merged 1 commit into from
Jun 23, 2016

Conversation

Jojo-Schmitz
Copy link
Contributor

No description provided.

@Jojo-Schmitz Jojo-Schmitz changed the title fix #116156: buttons don't render properly on HPII screens fix #116156: buttons don't render properly on HDPI screens Jun 23, 2016
@MarcSabatella
Copy link
Contributor

Right now I don't see a problem on my system (Ubuntu 14.04 with hi dpi screeen). WHat should I be looking for?

@lasconic
Copy link
Contributor

One of those buttons, when active, they looks bigger. http://musescore.org/node/116156
on macosx at least.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Jun 23, 2016

Maybe Mac/Retina only? Depending on Qt Version?
And the dialogs fixed here are currently disabled I think-
Travis failure seems entirely unrelated

@lasconic lasconic merged commit c6ec746 into musescore:master Jun 23, 2016
@Jojo-Schmitz Jojo-Schmitz deleted the button-icons branch June 23, 2016 18:38
@MarcSabatella
Copy link
Contributor

So all that is supposed to be needed to reproduce the problem is bring up Measure Properties and look at those buttons? They were fine for me before this most recent change, whether the buttons were active or not. Building again to make sure the most recent change didn't break anything for me.

@MarcSabatella
Copy link
Contributor

Well, Measure Properties is still fine. I don't offhand see any problems with the harmony editor dialog either (I am running with "-e") or with the instrument window (whether invoked from the new score wizard or edit / instruments). Not sure what the toolbar editor is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants